fix(MenuToggle): incorrect inheritance of HTMLInputElement #11145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MenuToggleCheckboxProps inherits from HTMLInputElement and defaultChecked is typed there as `undefined | boolean`, null is not a valid type. Found by typescript's `tsc` in strict mode.
Collaborator
|
Preview: https://patternfly-react-pr-11145.surge.sh A11y report: https://patternfly-react-pr-11145-a11y.surge.sh |
kmcfaul
approved these changes
Nov 7, 2024
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
LGTM. It might have gotten set that way because isChecked is boolean | null to support indeterminate checkboxes, but defaultChecked should be just a boolean.
tlabaj
requested review from
a team,
mattnolting,
tlabaj and
wise-king-sullyman
and removed request for
a team,
mattnolting and
wise-king-sullyman
tlabaj
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MenuToggleCheckboxProps inherits from HTMLInputElement and defaultChecked is typed there as
undefined | boolean, null is not a valid type.Found by typescript's
tscin strict mode.